Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12645 )

Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:

http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@153
PS1, Line 153: <li>Exponential moving average of time in queue for the past 10
             :                 queries</li>
is there intent here to highlight stats which are not a part of the regular 
pool metrics?
if yes them maybe also mention the "queuing reason of the query at the head of 
the queue"


http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@157
PS1, Line 157: the minimum
             :               and maximum query <codeph>MEM_LIMIT</codeph> ranges
should we mention here that it is referring to a pool config


http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@161
PS1, Line 161:  in real time.
maybe not mention "real-time" since that can mean the the info might be 
refreshed automatically (even though i know you have mentioned that in the next 
sentence).

You can probably say something along the lines of, The admission debug page 
displays information about all resource pool (to which queries have been 
submitted at least once), you can however click on the pool name to only 
display information relevant to that pool.


http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@168
PS1, Line 168:       </conbody>
also mention that you can reset the stats that keep track of historical data 
like Total-*, Exponential moving average of time in queue for the past 10 
queries and the histogram



--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 04 Mar 2019 22:29:14 +0000
Gerrit-HasComments: Yes

Reply via email to