Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12640 )
Change subject: IMPALA-7988: addendum: tolerate docker stop failure ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/12640/1/bin/start-impala-cluster.py@471 PS1, Line 471: check_call(["docker", "stop", container_name]) > On second thought, this one might never fail, because we are iterating over Yeah that was my thought. It could possibly race with the container being stopped (or exiting) in the background but I don't think that's a serious concern. -- To view, visit http://gerrit.cloudera.org:8080/12640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I211c9d29a9a30f9eebfff2973b4fb422d963f132 Gerrit-Change-Number: 12640 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2019 23:23:31 +0000 Gerrit-HasComments: Yes
