Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 )
Change subject: IMPALA-8100: Add initial support for Ranger ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12632/6/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/12632/6/be/src/service/frontend.cc@41 PS6, Line 41: "org.apache.impala.authorization.sentry.SentryAuthorizationFactory", It's a minor issue, but given that we enumerate AuthorizationProvider to be either SENTRY, RANGER, or NONE, does this really need to be a class? Could it be "--athorization_provider [sentry|ranger|none]". -- To view, visit http://gerrit.cloudera.org:8080/12632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cad9e609d20aae1ff645c84fd58a02afee70276 Gerrit-Change-Number: 12632 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2019 03:57:49 +0000 Gerrit-HasComments: Yes
