Hello Sahil Takiar, Todd Lipcon, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12658
to look at the new patch set (#2).
Change subject: IMPALA-8250: Remove unused THROW_IF_ERROR_WITH_LOGGING,
THROW_IF_EXC, and RETURN_IF_EXC.
......................................................................
IMPALA-8250: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and
RETURN_IF_EXC.
These macros have no references, so removing them. Found while
investigating JNI warnings in IMPALA-8250.
The following one-liner does a hap-hazard job of finding similar issues.
There are relatively few left, and none of them seemed problematic.
(for x in $(git grep '#define' be/src | grep -v be/src/kudu | grep -v
be/src/gutil | grep -v be/src/thirdparty | grep -v be/src/transport/config.h |
awk '{ print $2 }' | sed -e 's,(.*,,' | sort | uniq); do echo -n "$x "; git
grep -e $x | wc -l; done) | awk '$2 == 1 { print }'
Note that some of the macros were broken, because they
called other JNI functions before calling ExceptionClear().
Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
---
M be/src/util/jni-util.h
1 file changed, 0 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12658/2
--
To view, visit http://gerrit.cloudera.org:8080/12658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Gerrit-Change-Number: 12658
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
