Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12659 )
Change subject: Simplify JNI exception-handling macros. ...................................................................... Simplify JNI exception-handling macros. This simplifies the implementations of ABORT_IF_EXC() and CLEAN_EXIT_IF_EXC() by reducing them to usages of JniUtil::GetJniExceptionMsg() and our typical Status-handling macros. The existing implementations didn't clear the exception before calling additional Java methods, whereas JniUtil::GetJniExceptionMsg() already handled that correctly. I tested this manually by renaming a class in catalogd's startup sequence to a class that doesn't exist and checked that the crash logging was useful, containing both the Java and C++ stack traces with both macros. This is part of IMPALA-8250. Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Reviewed-on: http://gerrit.cloudera.org:8080/12659 Reviewed-by: Philip Zeyliger <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/jni-util.h 1 file changed, 9 insertions(+), 27 deletions(-) Approvals: Philip Zeyliger: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I38e9e51d3180328935f41bb118647113e5cd409c Gerrit-Change-Number: 12659 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
