Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12710 )

Change subject: IMPALA-6802 (part 3): Clean up authorization tests
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java
File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java:

http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@444
PS1, Line 444:               allExcept(TPrivilegeLevel.ALL, 
TPrivilegeLevel.SELECT)), onTable("functional",
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@446
PS1, Line 446:           .error(selectError("functional.alltypessmall"), 
onColumn("functional", "alltypes",
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@448
PS1, Line 448:                   "bigint_col", "float_col", "double_col", 
"date_string_col", "string_col",
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@451
PS1, Line 451:               "alltypessmall", new String[]{"id", "bool_col", 
"tinyint_col", "smallint_col",
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@453
PS1, Line 453:                   "string_col", "timestamp_col", "year", 
"month"}, TPrivilegeLevel.SELECT));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@531
PS1, Line 531:           .error(selectError("functional.alltypestiny"), 
onDatabase("functional", allExcept(
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/12710/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@850
PS1, Line 850:     authorize("show create table 
functional.notbl").error(accessError("functional.notbl"));
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/12710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7
Gerrit-Change-Number: 12710
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sun, 10 Mar 2019 01:31:15 +0000
Gerrit-HasComments: Yes

Reply via email to