Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12700 )

Change subject: IMPALA-7974: [DOCS] Document automatic invalidation via HMS 
notification
......................................................................


Patch Set 3:

(7 comments)

Vihang, please take a look at one question I had.

http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml
File docs/topics/impala_metadata.xml:

http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@196
PS3, Line 196:           for all databases and tables. You can disable the 
automatic invalidation via HMS
> May be rephrase this to something like:
Done


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@226
PS3, Line 226: <codeblock>CREATE DATABASE &lt;name> WITH DBPROPERTIES 
('impala.disableHmsSync'='true');</codeblock>
> Can we confirm this with someone else too? I am new to Impala and I relied
I checked and DBPROPERTIES is not supported in IMPALA for CREATE DATABASE.


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@231
PS3, Line 231:             DATABASE</codeph> statement in Hive. Impala does not 
support <codeph>ALTER
> Not sure if the convention is to use "Hive" or "Apache Hive"? Same comment
In titles and Menu, we use Apache Hive, but in the doc, we use Hive or Apache 
Hive.


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@258
PS3, Line 258:           latest.
> May as well add, that in such a case, the status of the event processor cha
Done


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@289
PS3, Line 289:           Under the web UI, there are two pages that presents 
the metrics for HMS sync processor
> change sync processor to event processor.
Done


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@290
PS3, Line 290: automatic metadata sync
> I think it is more appropriate to say "automatic metadata invalidate" inste
Should I change all "metadata sync" to "metadata invalidate"?


http://gerrit.cloudera.org:8080/#/c/12700/3/docs/topics/impala_metadata.xml@431
PS3, Line 431:                     or not. Possible states could be: STOPPED, 
ACTIVE, ERROR, NEEDS_INVALIDATE
> This might change to the following states after we merge IMPALA-7972 in 3.2
Done. Hopefully, IMPALA-7972 is merged to 3.2 in time.



--
To view, visit http://gerrit.cloudera.org:8080/12700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c8a4ec77152c839564b1d69c76dfa041a0ebd7f
Gerrit-Change-Number: 12700
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Mon, 11 Mar 2019 19:57:12 +0000
Gerrit-HasComments: Yes

Reply via email to