Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12732 )
Change subject: IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This looks good to me and covers the basics. I left a comment about a potential area where we could say more if we wanted to. http://gerrit.cloudera.org:8080/#/c/12732/3/docs/topics/impala_explain.xml File docs/topics/impala_explain.xml: http://gerrit.cloudera.org:8080/#/c/12732/3/docs/topics/impala_explain.xml@134 PS3, Line 134: <li>The analyzed query, in the output header, shows implicit casts and You may want to mention that the Analyzed Query may been rewritten to include various optimizations. One example that you can see in the example query in the doc is that 'constant folding' can simplify expressions in the sql text, so '1000 / 100' is simplified to '10'. There are other optimizations that can happen but probably you don't want to discuss hem all here. -- To view, visit http://gerrit.cloudera.org:8080/12732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ad5794d8a9b62cc7d01d023f56e700dc018f24b Gerrit-Change-Number: 12732 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2019 23:59:11 +0000 Gerrit-HasComments: Yes
