Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12578 )
Change subject: [stress] pull out QueryRunner ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py File tests/stress/query_runner.py: http://gerrit.cloudera.org:8080/#/c/12578/3/tests/stress/query_runner.py@443 PS3, Line 443: def fetch_and_set_profile(cursor, report): > Would it maybe make sense to just make this a member function of QueryRepor I guess I was thinking of QueryReport as mostly a struct rather than a richer object. -- To view, visit http://gerrit.cloudera.org:8080/12578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69c907a65147d082211837cbbaba7225aa4b67cb Gerrit-Change-Number: 12578 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2019 17:21:33 +0000 Gerrit-HasComments: Yes
