Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12399 )
Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12399/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12399/3//COMMIT_MSG@9 PS3, Line 9: When dataload runs on a machine without enough diskspace > Ah, never mind -- this clearly just applies to the minicluster. I will tighten up the language. It definitely is meant only for the minicluster. http://gerrit.cloudera.org:8080/#/c/12399/3/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/12399/3/testdata/bin/create-load-data.sh@202 PS3, Line 202: FIRST_MINICLUSTER_NODE="${IMPALA_CLUSTER_LOGS_DIR}/cdh${CDH_MAJOR_VERSION}-node-1" > I need to check, but my concern is that this will fail when this script get Good point, it has no ability to help when loading data to an external cluster, so I will disable this for that scenario. -- To view, visit http://gerrit.cloudera.org:8080/12399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8766d819c68345cac7d0a32258415ef1a188f53 Gerrit-Change-Number: 12399 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2019 22:38:17 +0000 Gerrit-HasComments: Yes
