Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 )
Change subject: IMPALA-7368: Add initial support for DATE type ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/12481/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12481/11//COMMIT_MSG@70 PS11, Line 70: complete DATE type implementation > should we consider turning it off by default and only enabling it once we'r It seems easier to leave it enabled so long as the current support is correct. I think we should convince ourselves that the testing is adequate before merging this though. http://gerrit.cloudera.org:8080/#/c/12481/11//COMMIT_MSG@72 PS11, Line 72: - Add date support to the random query generator. > should we transition TPC-DS test tables over to 'date' instead of 'string' Seems reasonable to do once the support is complete, I don't think it's a requirement to call DATE support "complete" though. http://gerrit.cloudera.org:8080/#/c/12481/11/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/12481/11/be/src/exprs/aggregate-functions-ir.cc@381 PS11, Line 381: val_struct->sum / val_struct->count > Is this correct behavior when the dates are negative? Dividing as signed in I agree avg(date) is likely not important. Kind-of nice to have for consistency but I guess if there's any concerns about the semantics we can just avoid the issues by not having it. -- To view, visit http://gerrit.cloudera.org:8080/12481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea8155ef09557e0afa2f8b2d0b2dc9d0896dc30f Gerrit-Change-Number: 12481 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 18 Mar 2019 16:13:36 +0000 Gerrit-HasComments: Yes
