Anonymous Coward (395) has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 )
Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12781/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12781/3//COMMIT_MSG@16 PS3, Line 16: Testing: Can you add a test to verify that the inline '--var=..' will work compatibly with the default 'keyval' in the config_file as well? LGTM otherwise. -- To view, visit http://gerrit.cloudera.org:8080/12781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73 Gerrit-Change-Number: 12781 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Anonymous Coward (395) Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2019 21:03:21 +0000 Gerrit-HasComments: Yes
