Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12792 )
Change subject: IMPALA-8320: Handle psutil error in tests ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Thank you for fixing this. http://gerrit.cloudera.org:8080/#/c/12792/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/12792/1/tests/common/impala_cluster.py@205 PS1, Line 205: cmdline = '' : try: : cmdline = process.cmdline : except psutil.NoSuchProcess: : # IMPALA-8320: psutil.Process.cmdline is a property and the process could have : # disappeared between the time we built the process list and now. : continue Nit: Do you think this should be below the comment about IMPALA-6889 and saving the cmdline? i.e. # IMPALA-6889: ... # ... [your code setting cmdline here] if len(cmdline) == 0: ... -- To view, visit http://gerrit.cloudera.org:8080/12792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5fec061f845d3deb6328e52e590a7a79196dfd4 Gerrit-Change-Number: 12792 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Mar 2019 20:10:54 +0000 Gerrit-HasComments: Yes
