Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12793 )
Change subject: Fix error when PUBLISH_DEPENDENCIES=0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12793/1/functions.sh File functions.sh: http://gerrit.cloudera.org:8080/#/c/12793/1/functions.sh@391 PS1, Line 391: if [[ "PUBLISH_DEPENDENCIES" -eq "1" ]]; then : : ${PUBLISH_DEPENDENCIES_S3=1} : : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=1} : else : : ${PUBLISH_DEPENDENCIES_S3=0} : : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=0} : fi I'm about to basically submit the same thing. I think this is equivalent to: : ${PUBLISH_DEPENDENCIES_S3=${PUBLISH_DEPENDENCIES}} -- To view, visit http://gerrit.cloudera.org:8080/12793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief2d6d9daf1b06091f3773b5abae0aebe0a3d15a Gerrit-Change-Number: 12793 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Comment-Date: Tue, 19 Mar 2019 23:33:20 +0000 Gerrit-HasComments: Yes
