Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py ...................................................................... Patch Set 1: (22 comments) http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@27 PS1, Line 27: from datetime import datetime flake8: F401 'datetime.datetime' imported but unused http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@35 PS1, Line 35: d flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@52 PS1, Line 52: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@104 PS1, Line 104: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@107 PS1, Line 107: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@110 PS1, Line 110: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@182 PS1, Line 182: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@236 PS1, Line 236: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@237 PS1, Line 237: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@238 PS1, Line 238: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@239 PS1, Line 239: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@302 PS1, Line 302: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@303 PS1, Line 303: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@304 PS1, Line 304: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@305 PS1, Line 305: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@416 PS1, Line 416: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@437 PS1, Line 437: n flake8: E121 continuation line under-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@460 PS1, Line 460: o flake8: E129 visually indented line with same indent as next logical line http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@484 PS1, Line 484: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@495 PS1, Line 495: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@525 PS1, Line 525: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/12798/1/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/12798/1/tests/common/impala_service.py@39 PS1, Line 39: d flake8: E128 continuation line under-indented for visual indent -- To view, visit http://gerrit.cloudera.org:8080/12798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5 Gerrit-Change-Number: 12798 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 02:04:39 +0000 Gerrit-HasComments: Yes