Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 )
Change subject: IMPALA-8326: Fix CreateDropRoleStmt toSql ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@7 PS2, Line 7: CreateDropRoleStmt toSql nit: CreateDropRoleStmt::toSql http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@9 PS2, Line 9: CreateDropRoleStmt class' toSql nit: CreateDropRoleStmt::toSql http://gerrit.cloudera.org:8080/#/c/12813/2//COMMIT_MSG@15 PS2, Line 15: - Ran all FE tests mention that you added a test for this. http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/12813/2/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1477 PS2, Line 1477: catalog_.addRole("test_role"); Put this in try/finally and delete it again afterwards. We don't want this role to be available for other tests. -- To view, visit http://gerrit.cloudera.org:8080/12813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25e4e1f680a6992779a47b5e6ad5092f27ba390a Gerrit-Change-Number: 12813 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 17:45:59 +0000 Gerrit-HasComments: Yes
