Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12812 )
Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. ...................................................................... Patch Set 1: Code-Review+2 (4 comments) Just couple nits, but LGTM. Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/12812/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12812/1//COMMIT_MSG@23 PS1, Line 23: nit: extra space http://gerrit.cloudera.org:8080/#/c/12812/1//COMMIT_MSG@30 PS1, Line 30: nit: extra space http://gerrit.cloudera.org:8080/#/c/12812/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12812/1/shell/impala_shell.py@1339 PS1, Line 1339: (leading_comment) nit: unnecessary parentheses in python http://gerrit.cloudera.org:8080/#/c/12812/1/shell/impala_shell.py@1340 PS1, Line 1340: leading_comment.encode('utf-8') I missed this in my previous patch :( Thanks for the fix! -- To view, visit http://gerrit.cloudera.org:8080/12812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8633935b6e0ca33594afd32ad242779555e09944 Gerrit-Change-Number: 12812 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2019 17:41:30 +0000 Gerrit-HasComments: Yes
