Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 )
Change subject: IMPALA-8100: Add initial support for Ranger ...................................................................... Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/12632/16/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/12632/16/be/src/service/frontend.cc@47 PS16, Line 47: with Range > this is only required if authorization is enabled, right? Yes. I guess instead of putting (Required) here can be confusing. Done. http://gerrit.cloudera.org:8080/#/c/12632/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/12632/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@72 PS16, Line 72: // Hive service definition does not have a concept of server. So we define : // server to mean all access to all resource sets. > Is this something we need to address? I can't recall all the cases in which It would be good if Hive could support it, but that might actually be a big change from the existing Ranger plugin for Hive. Technically having server as a root is better since we only need to make a single call instead of having 3 calls. We have certain statements that require server-level authorization, such as shutdown command, invalidate metadata (the global), and there are more I think. -- To view, visit http://gerrit.cloudera.org:8080/12632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cad9e609d20aae1ff645c84fd58a02afee70276 Gerrit-Change-Number: 12632 Gerrit-PatchSet: 17 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2019 01:05:33 +0000 Gerrit-HasComments: Yes
