Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12817 )
Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements ...................................................................... IMPALA-8328: Add missing ToSql test cases for authorization statements ToSql test cases were added for the following authorization statement classes: ShowRolesStmt, ShowGrantPrincipalStmt, GrantRevokeRoleStmt, GrantRevokePrivStmt. In addition, the ShowGrantPrincipalStmt::toSql, GrantRevokeRoleStmt::toSql, and PrivilegeSpec::toSql statements were found to be incorrect during testing and were updated to align with the grammar. Testing: - Ran all FE tests - Added new tests to ToSqlTest for the listed statements Change-Id: I828d0459b6c92f7f15006e2353ce108093aa9dab Reviewed-on: http://gerrit.cloudera.org:8080/12817 Reviewed-by: Fredy Wijaya <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/GrantRevokeRoleStmt.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java M fe/src/main/java/org/apache/impala/analysis/ShowGrantPrincipalStmt.java M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java 4 files changed, 176 insertions(+), 10 deletions(-) Approvals: Fredy Wijaya: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I828d0459b6c92f7f15006e2353ce108093aa9dab Gerrit-Change-Number: 12817 Gerrit-PatchSet: 5 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
