Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 )
Change subject: IMPALA-7918: Remove support for authorization policy file ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/12637/9/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/12637/9/be/src/service/frontend.cc@49 PS9, Line 49: By default, the " : "authorization policy will be loaded from the catalog server (via the statestore). I removed this comment from my earlier patch since this is no longer correct. http://gerrit.cloudera.org:8080/#/c/12637/9/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/12637/9/fe/src/main/java/org/apache/impala/service/Frontend.java@260 PS9, Line 260: if (authzConfig.getProvider() == AuthorizationProvider.SENTRY) { : SentryAuthorizationConfig sentryAuthzConfig = : (SentryAuthorizationConfig) authzConfig; : authzChecker_.set(new SentryAuthorizationChecker(sentryAuthzConfig, : getCatalog().getAuthPolicy())); : } else { : authzChecker_.set(authzFactory.newAuthorizationChecker()); : } we need to refactor this, e.g. if (authzConfig.isEnabled()) { ... } else { ... } http://gerrit.cloudera.org:8080/#/c/12637/9/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/12637/9/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@109 PS9, Line 109: // public AuthorizationTest(TestContext ctx) throws Exception { why is this commented out? -- To view, visit http://gerrit.cloudera.org:8080/12637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a52c2d5d35f58fbff8c088fb0bf30169625ebd Gerrit-Change-Number: 12637 Gerrit-PatchSet: 9 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 23 Mar 2019 00:40:02 +0000 Gerrit-HasComments: Yes
