John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12747 )
Change subject: IMPALA-7982: Add host network usage to profile ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc File be/src/util/system-state-info.cc: http://gerrit.cloudera.org:8080/#/c/12747/2/be/src/util/system-state-info.cc@73 PS2, Line 73: LOG(WARNING) << "Could not open " << path << ": " << GetStrErrMsg() << endl; Should you just print the error from the status? or is the errno still correctly preserved for GetStrErrMsg to determine the error msg? (Same applies to ReadCurrentProcNetDev) -- To view, visit http://gerrit.cloudera.org:8080/12747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cc74f87374080a74a13b7fb6e4da44a11d828ef Gerrit-Change-Number: 12747 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 27 Mar 2019 19:20:26 +0000 Gerrit-HasComments: Yes
