Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 )
Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12672/5/be/src/rpc/rpc-mgr.h File be/src/rpc/rpc-mgr.h: http://gerrit.cloudera.org:8080/#/c/12672/5/be/src/rpc/rpc-mgr.h@201 PS5, Line 201: const std::unique_ptr<Proxy>& proxy, : const ProxyMethod& rpc_call, const Request& request, Response* response, : const TQueryCtx& query_ctx, const char* error_msg, const int times_to_try, : const kudu::MonoDelta& timeout, const int server_busy_backoff_s = 0, : const char* debug_action = nullptr) > Although this function is inlined, It has grown over time to take too many My debug action patch will eliminate the 'error_msg', 'debug_action', and 'query_ctx' parameters, assuming that the approach I've taken there will pass review. -- To view, visit http://gerrit.cloudera.org:8080/12672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693151c35e02235665b3c285a48c585973d390 Gerrit-Change-Number: 12672 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2019 16:56:01 +0000 Gerrit-HasComments: Yes
