Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12862 )
Change subject: Install newer nss version in centos 6.6 ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Looks good, just a couple of suggestions for comments. http://gerrit.cloudera.org:8080/#/c/12862/3/docker/all/assert-dependencies-present.py File docker/all/assert-dependencies-present.py: http://gerrit.cloudera.org:8080/#/c/12862/3/docker/all/assert-dependencies-present.py@122 PS3, Line 122: clone Similarly, I'd suggest mentioning HTTPS explicitly here. (the git://.... protocol would always work but it is insecure, so we wouldn't want to use that). http://gerrit.cloudera.org:8080/#/c/12862/3/docker/redhat6.df File docker/redhat6.df: http://gerrit.cloudera.org:8080/#/c/12862/3/docker/redhat6.df@51 PS3, Line 51: can't clone from : # github. Maybe phrase this a bit more explicitly: the real problem is that Github now enforces TLSv1.2, which the CentOS 6.6 version of NSS cannot handle? -- To view, visit http://gerrit.cloudera.org:8080/12862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66549477ec9378faeda46a98cf6556a3207979eb Gerrit-Change-Number: 12862 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Mar 2019 21:19:09 +0000 Gerrit-HasComments: Yes
