Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 )
Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet ...................................................................... Patch Set 13: Code-Review+2 (3 comments) Only had some nits, otherwise this looks good to me. http://gerrit.cloudera.org:8080/#/c/12247/9/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/12247/9/be/src/runtime/timestamp-test.cc@740 PS9, Line 740: EQ(MI > I have rewritten the code to always reset min_date. I think that it is easi I feel I'm slightly in favor of adding proper distinct variables instead of re-using min_date. http://gerrit.cloudera.org:8080/#/c/12247/13/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/12247/13/be/src/runtime/timestamp-test.cc@743 PS13, Line 743: Add 250ns The comments should now reflect that you're setting it explicitly instead of adding. Also check the one for max* below http://gerrit.cloudera.org:8080/#/c/12247/13/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/12247/13/be/src/runtime/timestamp-value.h@196 PS13, Line 196: 1'000'000'000LL We have NANOS_PER_SEC in timestamp-value-inline.h, use here, too, and elsewhere in this file? -- To view, visit http://gerrit.cloudera.org:8080/12247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib41ad532ec902ed5a9a1528513726eac1c11441f Gerrit-Change-Number: 12247 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Comment-Date: Fri, 29 Mar 2019 23:37:45 +0000 Gerrit-HasComments: Yes
