Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 )
Change subject: IMPALA-8309: add user authorization_provider flag ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@113 PS1, Line 113: final AuthorizationFactory authzFactory = JniFrontend.authzFactoryFrom(BackendConfig.INSTANCE); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@92 PS1, Line 92: Class<? extends AuthorizationFactory> authorization_factory_class, String authorization_provider) { line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@93 PS1, Line 93: return authCfg(authorization_factory_class.getCanonicalName(), authorization_provider); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@110 PS1, Line 110: public void testAuthorizationPolicySelection_FactoryTakesPrecedenceOverProvider() throws Exception { line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@113 PS1, Line 113: JniFrontend.authzFactoryClassNameFrom(authCfg(SentryAuthorizationFactory.class, "ranger")) line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@118 PS1, Line 118: JniFrontend.authzFactoryClassNameFrom(authCfg(RangerAuthorizationFactory.class, "sentry")) line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@123 PS1, Line 123: JniFrontend.authzFactoryClassNameFrom(authCfg(SentryAuthorizationFactory.class, "sentry")) line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12901/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@128 PS1, Line 128: JniFrontend.authzFactoryClassNameFrom(authCfg(RangerAuthorizationFactory.class, "ranger")) line too long (98 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I001c20505ba4f0562b60fdef73d15308e8500c19 Gerrit-Change-Number: 12901 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 01 Apr 2019 05:23:28 +0000 Gerrit-HasComments: Yes
