Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12882 )
Change subject: Include python-dev in all build images ...................................................................... Include python-dev in all build images Thrift doesn't fail the build if it fails to find the python development headers, it instead silently builds without support for the TBinaryProtocolAccelerated class. This commit adds python-dev to the missing docker images and adds a couple of assertions to ensure we fail the build whenever this happens. Change-Id: Iac6186317b943e3bb7609c9309d7bfdde245e4d8 Reviewed-on: http://gerrit.cloudera.org:8080/12882 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Tim Armstrong <tarmstr...@cloudera.com> --- M docker/all/assert-dependencies-present.py M docker/debian7.df M docker/debian8.df M docker/ubuntu1204.df M docker/ubuntu1404.df M docker/ubuntu1604.df M docker/ubuntu1804.df M source/thrift/build.sh 8 files changed, 22 insertions(+), 1 deletion(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iac6186317b943e3bb7609c9309d7bfdde245e4d8 Gerrit-Change-Number: 12882 Gerrit-PatchSet: 5 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
