Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12894 )
Change subject: IMPALA-8380: Bump Postgres JDBC driver version to 9.4 ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12894/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/12894/1/bin/impala-config.sh@567 PS1, Line 567: jre7 > I'm curious why we chose the one with jre7 instead of the default one. Possibly for compatibility versions but I'll give it a try with the default one for now. http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@451 PS1, Line 451: <!-- https://mvnrepository.com/artifact/org.postgresql/postgresql --> > nit: this comment is not necessary I actually found it helpful, but that's because I didn't know that location. Happy to remove it though. http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@453 PS1, Line 453: > nit: use 2 spaces Done http://gerrit.cloudera.org:8080/#/c/12894/1/fe/pom.xml@455 PS1, Line 455: 9.4.1212.jre7 > shouldn't we be getting it from the IMPALA_POSTGRES_JDBC_DRIVER_VERSION env Done -- To view, visit http://gerrit.cloudera.org:8080/12894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5423c18a9f8346dda7dae617b1764638b57b6c Gerrit-Change-Number: 12894 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2019 21:15:03 +0000 Gerrit-HasComments: Yes
