Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 )
Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12911/1//COMMIT_MSG@13 PS1, Line 13: Run impala-shell with or w/o PYTHON_EGG_CACHE configured I thought this wrapper is bypassed when calling bin/impala-shell.sh . Did you build a tar ball and test this script? http://gerrit.cloudera.org:8080/#/c/12911/1/shell/impala-shell File shell/impala-shell: http://gerrit.cloudera.org:8080/#/c/12911/1/shell/impala-shell@41 PS1, Line 41: if [ ! ${PYTHON_EGG_CACHE} ]; then : PYTHON_EGG_CACHE=/tmp/impala-shell-python-egg-cache-${USER} : fi I think this can be simplified to foo=${foo:-bar} style -- To view, visit http://gerrit.cloudera.org:8080/12911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I695b2b31d9045eef1a53268f6516858935aed508 Gerrit-Change-Number: 12911 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Thu, 04 Apr 2019 16:26:30 +0000 Gerrit-HasComments: Yes
