Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12179 )
Change subject: IMPALA-7640: RENAME on managed Kudu table should rename Kudu table ...................................................................... Patch Set 4: (1 comment) Please be sure to get the docs updated to reflect this change, eg: http://impala.apache.org/docs/build/html/topics/impala_kudu.html http://impala.apache.org/docs/build/html/topics/impala_tables.html http://gerrit.cloudera.org:8080/#/c/12179/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/12179/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2378 PS4, Line 2378: oldTbl instanceof KuduTable && !Table.isExternalTable(msTbl) Is it possible to do this check as part of altersKuduTable() (eg. by adding 'msTbl' as a parameter) and then call your new renameKuduTable() in alterKuduTable() so that this follows the same code path as other 'alter' operations that need to be reflected both in HMS and in Kudu? -- To view, visit http://gerrit.cloudera.org:8080/12179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77e7583ce93cba8f6e743c4bedd9900ae1fae081 Gerrit-Change-Number: 12179 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 18:51:40 +0000 Gerrit-HasComments: Yes
