David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12957 )
Change subject: IMPALA-8393: setup-ranger in create-load-data.sh breaks for clusters ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Looks basically good to me. I'll let Fredy give the final +2 after his comments get addressed. http://gerrit.cloudera.org:8080/#/c/12957/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12957/2//COMMIT_MSG@7 PS2, Line 7: setup-ranger in create-load-data.sh breaks for clusters > nit: it's a bit hard to parse. Reword? Agreed -- could be something like: "Skip ranger setup steps in environments that don't support it." -- To view, visit http://gerrit.cloudera.org:8080/12957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie81dda992cf29792468580b182e570132d5ce0a1 Gerrit-Change-Number: 12957 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2019 18:45:40 +0000 Gerrit-HasComments: Yes
