Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 )
Change subject: IMPALA-8338 : Check CREATION_TIME of databases in event processor to avoid incorrect/redundant invalidates ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@208 PS4, Line 208: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_FILTERED_METRIC).inc(numFilteredEvents); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@899 PS4, Line 899: * (For instance, when user does a create db, drop db and create db again with the same dbName.) line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@285 PS4, Line 285: long filteredCount = eventsProcessor_.getMetrics().getCounter(MetastoreEventsProcessor.EVENTS_FILTERED_METRIC).getCount(); line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@293 PS4, Line 293: // Here, we expect the events CREATE_DB, DROP_DB, CREATE_DB for the same Database name. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@294 PS4, Line 294: // Hence, the DROP_DB event should not be processed, as the CREATION_TIME of the catalog's line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@295 PS4, Line 295: // Database object should be greater than that in the DROP_DB notification event. Two events line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@296 PS4, Line 296: // are filtered here, 1 : first CREATE_DATABASE as it is followed by another create of the same name. line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/12938/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@299 PS4, Line 299: .getCounter(MetastoreEventsProcessor.EVENTS_FILTERED_METRIC).getCount() - filteredCount); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fd3685cf7261e4953f4f884850489a47c5bbd6c Gerrit-Change-Number: 12938 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Krishna <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 07:45:44 +0000 Gerrit-HasComments: Yes
