Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12963 )
Change subject: IMPALA-8385: Refactor Sentry admin user check ...................................................................... Patch Set 6: Code-Review+2 (2 comments) lgtm. http://gerrit.cloudera.org:8080/#/c/12963/5/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/12963/5/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java@69 PS5, Line 69: private final static TBinaryProtocol.Factory THRIFT_PROTOCOL = : new TBinaryProtocol.Factory(); you could get rid of this using JniUtil. serializeToThrift(input) ? http://gerrit.cloudera.org:8080/#/c/12963/5/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java@238 PS5, Line 238: checkSentryAdmin nit: call it validateSentryAdmin...() ? Since it validates and throws.. -- To view, visit http://gerrit.cloudera.org:8080/12963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911228b09af7eed5d5dc002b20591ef64dc625d3 Gerrit-Change-Number: 12963 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 16:48:02 +0000 Gerrit-HasComments: Yes
