Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 )
Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12968/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/12968/1/be/src/exec/hdfs-scan-node.cc@561 PS1, Line 561: // TODO: Cancelling the RequestContext will wait on in-flight IO. We should > RequestContext::Cancel() calls ScanRange::CancelInternal() - I might miss i Ah I see what you mean and why it's misleading. So when I wrote that comment I was trying to say that "in flight reads have finished" is *not* a post-condition of CancelInternal(). But I can see that that comment could be taken to imply some kind of non-blocking behaviour, and it *can* get blocked on an in-flight I/O because of file_reader_->lock(). So yeah, it could be clarified for sure. -- To view, visit http://gerrit.cloudera.org:8080/12968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4881a3e5bfda64e8d60af95ad13b450cf7f8c130 Gerrit-Change-Number: 12968 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 09 Apr 2019 22:35:12 +0000 Gerrit-HasComments: Yes
