Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 )
Change subject: IMPALA-6718: Add support for column-level permissions on views ...................................................................... Patch Set 3: (3 comments) sorry for the delay here. http://gerrit.cloudera.org:8080/#/c/12959/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12959/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-6718: Add support for column-level permissions on views Does it make sense to call out Hive's behavior here and mention that we are compatible with it? Specially the part about view's column level privs here mean that they only apply to view's columns and not base table's columns that view's column map to. Even if someone revokes base table column's privs, someone with view's col access can still access them. (feel free to add some test coverage for it if you think that helps). http://gerrit.cloudera.org:8080/#/c/12959/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12959/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@550 PS3, Line 550: boolean isCatalogView = view != null && !view.isLocalView(); Add a comment why we skip these? http://gerrit.cloudera.org:8080/#/c/12959/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@553 PS3, Line 553: if (!(expr instanceof SlotRef)) continue; doesn't look right to me.. (add some test coverage) how about something like select 2 * v.id from v (doesn't always need to be a slotref) -- To view, visit http://gerrit.cloudera.org:8080/12959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81e683212cba22cc0fa5fc091ec3c799fa33e14 Gerrit-Change-Number: 12959 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 15 Apr 2019 01:51:01 +0000 Gerrit-HasComments: Yes
