Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 )
Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. ...................................................................... Patch Set 12: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/12938/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12938/12//COMMIT_MSG@7 PS12, Line 7: Check CREATION_TIME in event : processor to avoid incorrect deletion of Database objects. wrap to single line? Something like "consider ctime while processing database events"... http://gerrit.cloudera.org:8080/#/c/12938/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/12938/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1546 PS12, Line 1546: if (catalogDb == null) { : return null; : } nit: single line http://gerrit.cloudera.org:8080/#/c/12938/12/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1552 PS12, Line 1552: this nit: not needed -- To view, visit http://gerrit.cloudera.org:8080/12938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fd3685cf7261e4953f4f884850489a47c5bbd6c Gerrit-Change-Number: 12938 Gerrit-PatchSet: 12 Gerrit-Owner: Bharath Krishna <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Krishna <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2019 22:26:32 +0000 Gerrit-HasComments: Yes
