Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12814 )
Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate ...................................................................... Patch Set 7: (6 comments) I'm ready to +2 once you undo some of the cleanup in files that wouldn't be touched otherwise. http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@19 PS7, Line 19: This is valid cleanup but it's better to only do cleanup in files that you touch with a patch. http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java File fe/src/main/java/org/apache/impala/analysis/AnalyticWindow.java: PS7: Can you undo the unrelated changes in this file? If you want to submit a separate cleanup patch, that's fine, it just gets confusing if unrelated changes creep into a patch. http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java@20 PS7, Line 20: import java.util.function.Supplier; Can you undo this unrelated change? http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/planner/PlanNode.java@602 PS7, Line 602: result *= Math.pow(selectivities.get(i), 1.0 / (i + 1)); Can you undo this unrelated change? http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/planner/PlanNode.java@890 PS7, Line 890: double backoffExp = 1.0 / (sortedConjuncts.size() + 1); Can you undo this unrelated change? http://gerrit.cloudera.org:8080/#/c/12814/7/fe/src/main/java/org/apache/impala/util/Graph.java File fe/src/main/java/org/apache/impala/util/Graph.java: PS7: Can you undo the unrelated changes in this file? -- To view, visit http://gerrit.cloudera.org:8080/12814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b078113ccc1aa49b0cea0c86dff2e02e1dd0e23 Gerrit-Change-Number: 12814 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 05:54:46 +0000 Gerrit-HasComments: Yes
