Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )
Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 ...................................................................... Patch Set 10: Code-Review+1 (1 comment) This looks fine to me. I can +2 once other reviewers have a chance to look. http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13002/10/bin/bootstrap_toolchain.py@420 PS10, Line 420: download_cdp_components This is getting very similar to download_cdh_components. At some point, we should consider combining them. -- To view, visit http://gerrit.cloudera.org:8080/13002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada Gerrit-Change-Number: 13002 Gerrit-PatchSet: 10 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Hector Acosta <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 20:46:36 +0000 Gerrit-HasComments: Yes
