Bharath Krishna has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 )
Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase ...................................................................... Patch Set 1: (2 comments) Hi Bharath, thanks for the review. I have added comments to explain the limitation about CREATION_TIME, let me know if it makes sense. http://gerrit.cloudera.org:8080/#/c/13058/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13058/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@278 PS1, Line 278: // Adding sleep here to make sure that the CREATION_TIME is not same : // as the previous CREATE_DB operation, so as to trigger the filtering logic : // based on CREATION_TIME in DROP_DB event processing. This is currently a : // limitation : the DROP_DB event filtering expects that while processing events, : // the CREATION_TIME of two Databases with same name won't have the same : // creation timestamp. : sleep(2000); > Do you need this if all the creates are via Hive? (event processor is expec Yes, so the same applies to Hive as well. We don't want events to have same CREATION_TIME as mentioned below. http://gerrit.cloudera.org:8080/#/c/13058/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@709 PS1, Line 709: This is currently a : // limitation : the DROP_TABLE event filtering expects that while processing events, : // the CREATION_TIME of two tables with same name won't have the same : // creation timestamp. > I'm not totally sure I understand how this is a limitation. Isn't the proce It is expected to rely on the ctime, but limitation is that we don't expect a CREATE_TABLE and DROP_TABLE on the same table happen in the same second. In that case, the logic would fail to filter out the event. -- To view, visit http://gerrit.cloudera.org:8080/13058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30bf4535d54c9cd8d257b528dc7a1b42f106800d Gerrit-Change-Number: 13058 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Krishna <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Krishna <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 19:51:43 +0000 Gerrit-HasComments: Yes
