Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13060 )
Change subject: IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY ...................................................................... Patch Set 1: (3 comments) LGTM. Some comments and one question. http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/common/global-flags.cc@154 PS1, Line 154: DEFINE_string(debug_actions, "", "For testing only. Uses the same format as the debug " : "action query options, but allows for injection of debug actions in code paths where " : "query options are not available."); If set, should this also affect the default value of debug action query options ? In other words, whatever is set in FLAGS_debug_action will be universally applied to all sessions' query options. Please see idle_session_timeout as an example. We rely on FLAGS_idle_session_timeout as the value but it can be overridden per session: https://github.com/apache/impala/blob/master/be/src/service/impala-hs2-server.cc#L319-L341 That said, it's perfectly fine to also say it's not applicable in this case. http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/service/data-stream-service.cc@97 PS1, Line 97: EndDataStreamResponsePB* response, RpcContext* rpc_context) { May wanna add a delay here too ? http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/util/debug-util.h File be/src/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/13060/1/be/src/util/debug-util.h@144 PS1, Line 144: /// 'query_options.debug_action' is non-empty. or FLAGS_debug_action -- To view, visit http://gerrit.cloudera.org:8080/13060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I712b188e0cdf91f431c9b94052501e5411af407b Gerrit-Change-Number: 13060 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Apr 2019 22:54:57 +0000 Gerrit-HasComments: Yes
