Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13057 )
Change subject: IMPALA-8270: fix MemTracker teardown in FeSupport ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13057/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13057/1//COMMIT_MSG@42 PS1, Line 42: local_query_state_ > Should this be instance_mem_tracker_? Done http://gerrit.cloudera.org:8080/#/c/13057/1/be/src/runtime/runtime-state-test.cc File be/src/runtime/runtime-state-test.cc: http://gerrit.cloudera.org:8080/#/c/13057/1/be/src/runtime/runtime-state-test.cc@43 PS1, Line 43: TEST > I think this should be TEST_F? (Or use TEST and remove the RuntimeStateTest Done -- To view, visit http://gerrit.cloudera.org:8080/13057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If815130cd4db00917746f10b28514f779ee254f0 Gerrit-Change-Number: 13057 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2019 00:24:07 +0000 Gerrit-HasComments: Yes
