Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Refactor seems straightforward and makes sense to me. Thanks for breaking this up into a separate change. Definitely makes it easy for review. http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@128 PS3, Line 128: Performs a refresh authorization. nit: Mention what it actually does? http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@130 PS3, Line 130: when the operation is INVALIDATE METADATA, resetVersions will be : * set to true. That means the versions in the catalog objects : * will need to be incremented. nit: swap this? When resetVersions is true, object versions are not incremented. Used for INVALIDATE METADATA... http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@199 PS3, Line 199: // TODO: IMPALA-8293 (part 2) : return new AuthorizationDelta(); nit: NotImplementedException...? -- To view, visit http://gerrit.cloudera.org:8080/13065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568 Gerrit-Change-Number: 13065 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2019 16:35:09 +0000 Gerrit-HasComments: Yes
