Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 )
Change subject: IMPALA-8446: Create a unit test for Admission Controller. ...................................................................... Patch Set 2: (4 comments) Thanks Tim. I made fixes in patch set 2. http://gerrit.cloudera.org:8080/#/c/13078/1/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/13078/1/be/src/scheduling/admission-controller-test.cc@49 PS1, Line 49: static const string HOST_2 = "host2:25000"; > nit: static const or static constexpr Done http://gerrit.cloudera.org:8080/#/c/13078/1/be/src/scheduling/admission-controller-test.cc@86 PS1, Line 86: onst string pool_name, TPoolStats stats) { : // Build topic item. > unused args? Done http://gerrit.cloudera.org:8080/#/c/13078/1/be/src/scheduling/admission-controller-test.cc@109 PS1, Line 109: ckPoo > values Done http://gerrit.cloudera.org:8080/#/c/13078/1/be/src/scheduling/admission-controller-test.cc@115 PS1, Line 115: > Maybe ASSERT_OK since the rest of assertions don't make sense if this fails Done -- To view, visit http://gerrit.cloudera.org:8080/13078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a840590b868f2df1a06f3f397b7b0fc2b29462c Gerrit-Change-Number: 13078 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 00:28:03 +0000 Gerrit-HasComments: Yes
