Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13083 )
Change subject: IMPALA-7290: part 1: clean up shell tests ...................................................................... Patch Set 5: (18 comments) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/beeswax/impala_beeswax.py File tests/beeswax/impala_beeswax.py: http://gerrit.cloudera.org:8080/#/c/13083/5/tests/beeswax/impala_beeswax.py@116 PS5, Line 116: flake8: E261 at least two spaces before inline comment http://gerrit.cloudera.org:8080/#/c/13083/5/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/13083/5/tests/custom_cluster/test_client_ssl.py@221 PS5, Line 221: s flake8: E501 line too long (104 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@33 PS5, Line 33: from util import get_impalad_host_port, get_impalad_host_port, get_shell_cmd flake8: F811 redefinition of unused 'get_impalad_host_port' from line 33 http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@33 PS5, Line 33: from util import get_impalad_host_port, get_impalad_host_port, get_shell_cmd flake8: F401 'util.get_shell_cmd' imported but unused http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@204 PS5, Line 204: flake8: E203 whitespace before ',' http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@217 PS5, Line 217: flake8: E203 whitespace before ',' http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@519 PS5, Line 519: F flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@642 PS5, Line 642: ' flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_commandline.py@872 PS5, Line 872: u flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_interactive.py@41 PS5, Line 41: from util import (assert_var_substitution, ImpalaShell, get_impalad_host_port, flake8: F401 'util.get_impalad_host_port' imported but unused http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_interactive.py@252 PS5, Line 252: flake8: E203 whitespace before ',' http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_interactive.py@451 PS5, Line 451: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/test_shell_interactive.py@463 PS5, Line 463: r flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py@116 PS5, Line 116: def get_impalad_host_port(vector): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py@122 PS5, Line 122: def get_impalad_port(vector): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py@126 PS5, Line 126: def get_shell_cmd(vector): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py@129 PS5, Line 129: h flake8: F841 local variable 'host_port' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/13083/5/tests/shell/util.py@133 PS5, Line 133: def get_open_sessions_metric(vector): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/13083 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5ab7f4817e690b7d3be08d71f8f14364b84412 Gerrit-Change-Number: 13083 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 17:23:16 +0000 Gerrit-HasComments: Yes
