Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13091 )
Change subject: [acid] Predicate to test if dir must be included. ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@123 PS2, Line 123: fileStatuses = FileSystemUtil.listStatus(fs, partDir_, recursive_, pathPredicate_); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@563 PS2, Line 563: FileMetadataLoader loader = new FileMetadataLoader(e.getKey(), /*recursive=*/isRecursive, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@607 PS2, Line 607: * TODO:Sudhanshu: Move this to interface and then use this implementation in BaseTableRef line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@567 PS2, Line 567: RecursingIterator(FileSystem fs, Path startPath, Predicate<String> predicate) throws IOException { line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java File fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java: http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java@129 PS2, Line 129: when(fs.listStatusIterator(new Path("/user/hive/warehouse/test/delta_0000023_0000023_0000"))). line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java@131 PS2, Line 131: when(fs.listStatusIterator(new Path("/user/hive/warehouse/test/delta_0000024_0000024_0000"))). line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java@138 PS2, Line 138: new FileSystemUtil.RecursingIterator(fs, new Path("/user/hive/warehouse/test"), x->true); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/13091/2/fe/src/test/java/org/apache/impala/common/RecursingIteratorTest.java@153 PS2, Line 153: new FileSystemUtil.RecursingIterator(fs, new Path("/user/hive/warehouse/test"), line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0e88281d277127c9499d37b95fbba55dcc7761c Gerrit-Change-Number: 13091 Gerrit-PatchSet: 2 Gerrit-Owner: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 22:13:31 +0000 Gerrit-HasComments: Yes
