Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13005 )

Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 
3.1.0
......................................................................


Patch Set 5:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/13005/5/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/13005/5/bin/impala-config.sh@196
PS5, Line 196: # When USE_CDP_HIVE is set we use the latest hive version 
available to deply in minicluster
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/13005/5/bin/impala-config.sh@200
PS5, Line 200:   # TODO(Vihang) we should repackage the tarballs so that the 
src and binaries are extracted
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/13005/5/bin/impala-config.sh@209
PS5, Line 209:   export 
HIVE_HOME="$IMPALA_TOOLCHAIN/cdh_components-${CDH_BUILD_NUMBER}/hive-${MINICLUSTER_HIVE_VERSION}"
line too long (106 > 90)


http://gerrit.cloudera.org:8080/#/c/13005/5/bin/impala-config.sh@546
PS5, Line 546: export 
HIVE_METASTORE_THRIFT_DIR=$CDP_COMPONENTS_HOME/apache-hive-${IMPALA_HIVE_VERSION}-src/standalone-metastore/src/main/thrift
line too long (129 > 90)


http://gerrit.cloudera.org:8080/#/c/13005/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/13005/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1073
PS5, Line 1073:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13005/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1169
PS5, Line 1169:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13005/5/testdata/bin/run-hive-server.sh
File testdata/bin/run-hive-server.sh:

http://gerrit.cloudera.org:8080/#/c/13005/5/testdata/bin/run-hive-server.sh@66
PS5, Line 66: export HIVE_METASTORE_HADOOP_OPTS="-verbose:class -Xdebug 
-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=30010"
line too long (121 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/13005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45a4dadbdfe30a02f722dbd917a49bc182fc6436
Gerrit-Change-Number: 13005
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 02:07:16 +0000
Gerrit-HasComments: Yes

Reply via email to