Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 )
Change subject: IMPALA-8381: Optimize ParquetPlainEncoder::DecodeBatch() for simple types ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/12985/13/be/src/exec/parquet/parquet-plain-test.cc File be/src/exec/parquet/parquet-plain-test.cc: http://gerrit.cloudera.org:8080/#/c/12985/13/be/src/exec/parquet/parquet-plain-test.cc@401 PS13, Line 401: > nit: unnecessary line? Maybe I should add a comment there: // BYTE_ARRAYs store the length of the array on 4 bytes. -- To view, visit http://gerrit.cloudera.org:8080/12985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57b7d2573bb6dfd038e581acb3bd8ea1565aa20d Gerrit-Change-Number: 12985 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Apr 2019 15:28:19 +0000 Gerrit-HasComments: Yes
