Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13094 )

Change subject: IMPALA-1856: MetadataOp.getTypeInfo() does not return all 
supported types.
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

I had one nit, after that I can start the merge

http://gerrit.cloudera.org:8080/#/c/13094/3/fe/src/main/java/org/apache/impala/catalog/Type.java
File fe/src/main/java/org/apache/impala/catalog/Type.java:

http://gerrit.cloudera.org:8080/#/c/13094/3/fe/src/main/java/org/apache/impala/catalog/Type.java@129
PS3, Line 129:   /**
nit: space before comment



--
To view, visit http://gerrit.cloudera.org:8080/13094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdccde7c32e52ed1b0c7b13a22171e8bcd7f1f2d
Gerrit-Change-Number: 13094
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 24 Apr 2019 19:45:30 +0000
Gerrit-HasComments: Yes

Reply via email to