Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13114
to review the following change.
Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on
HDFS tables
......................................................................
IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables
This is a grab-bag of small fixes necessary to get most queries on HDFS
tables passing with the correct plans:
* Change the loading of tables to check for other table types before
checking for FS tables, since without specific checks against
various properties, other tables may look like FS tables and try to
instantiate LocalFsTable incorrectly.
* Return -1 for extrapolated row count -- the previous 0 value was
convincing the planner that it had a valid value.
* Fix up the handling of BuiltinsDb so that we don't depend on
ImpaladCatalog to have been loaded in order to instantiate it.
* Properly handle the case where all partitions are pruned by a
predicate.
With this change, about half of the tests in PlannerTest pass. The tests
that don't pass all rely on views, HBase tables, etc.
Conflicts:
fe/src/main/java/org/apache/impala/analysis/FunctionName.java
Need to Modify:
fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
Change-Id: I6f603e62b7a013c148c0905ebdec2f4303f9c4e5
Reviewed-on: http://gerrit.cloudera.org:8080/10798
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Todd Lipcon <[email protected]>
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
15 files changed, 67 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/13114/1
--
To view, visit http://gerrit.cloudera.org:8080/13114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f603e62b7a013c148c0905ebdec2f4303f9c4e5
Gerrit-Change-Number: 13114
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
