Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13127 )

Change subject: IMPALA-8454 (part 3): enable recursive file listing by default
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Looks pretty good to me.

http://gerrit.cloudera.org:8080/#/c/13127/1/tests/metadata/test_recursive_listing.py
File tests/metadata/test_recursive_listing.py:

http://gerrit.cloudera.org:8080/#/c/13127/1/tests/metadata/test_recursive_listing.py@59
PS1, Line 59: execute
nit: execute_query_expect_success in multiple places? (does an extra assert on 
result.success)



--
To view, visit http://gerrit.cloudera.org:8080/13127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib30e2bcaf820210f2faa8f159d1af2f947a4d0e8
Gerrit-Change-Number: 13127
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sudhanshu Arora <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Fri, 26 Apr 2019 06:38:10 +0000
Gerrit-HasComments: Yes

Reply via email to