Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 )
Change subject: IMPALA-8253: Draft - Parquet delta encoding and decoding. ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-coder-test-data.h File be/src/exec/parquet/parquet-delta-coder-test-data.h: http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-coder-test-data.h@454 PS6, Line 454: const std::vector<int32_t> values_are_the_same_plain = {3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-coder-test-data.h@471 PS6, Line 471: const std::vector<int32_t> delta_is_zero_for_each_block_plain = {0, 0, 0, 0, 0, 0, 0, 0, 0, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-encoder.h File be/src/exec/parquet/parquet-delta-encoder.h: http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-encoder.h@47 PS6, Line 47: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12621/6/be/src/exec/parquet/parquet-delta-encoder.h@115 PS6, Line 115: const int header_size = HeaderSize(most_negative_first_value, MAX_TOTAL_VALUE_COUNT); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7378ac1a490a6c89a0a4349aae86cbc0fbc80f8 Gerrit-Change-Number: 12621 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2019 11:31:40 +0000 Gerrit-HasComments: Yes
